Repository navigation
Link stdc++ - #1139
Merged
filmor merged 5 commits intoMay 11, 2020
Merged
Link stdc++#1139filmor merged 5 commits into
filmor merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
filmor
force-pushed
the
link-stdc++
branch
2 times, most recently
from
ce7e1fb to
73fc723
Compare
May 10, 2020 19:21
Copy link
Copy Markdown
Member
|
Hm, I'd rather have Mono fix their side. Most platforms don't even need this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
What's the point? This is broken now, and with clr-loader this thing is not needed anymore anyway. I just want to fix this as far as possible before the release to have a reasonable frozen state. |
Sorry, something went wrong.
lostmsu
reviewed
May 10, 2020
Comment thread
src/monoclr/pynetinit.c
Outdated
lostmsu
approved these changes
May 11, 2020
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
* Fix geninterop.py include paths * Ensure that monoclr is linked as a C++ library * Force preload libmono and fix bug in LD_LIBRARY_PATH forwarding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Links monoclr as a C++ library and thus includes libstdc++ and whatever else g++ adds. Additionally, it force-loads libmono-2.0 on Linux with RTLD_GLOBAL to make sure the symbols are in place when libmono-native.so is being loaded.
Does this close any currently open issues?
I hope this fixes #939. The second part fixes #1034 on my machine.
Checklist
Check all those that are applicable and complete.