Repository navigation
Improve "No constructor matches given arguments" message with more details - #1143
filmor merged 1 commit into
Conversation
Sorry, something went wrong.
…tails Similar to pythonnet#900, but for constructors (reuses the same code) Related issues: pythonnet#811, pythonnet#265, pythonnet#1116
Codecov Report
@@ Coverage Diff @@
## master #1143 +/- ##
=======================================
Coverage 86.66% 86.66%
=======================================
Files 1 1
Lines 300 300
=======================================
Hits 260 260
Misses 40 40
Continue to review full report at Codecov.
|
Sorry, something went wrong.
| var description = Runtime.PyObject_Unicode(type); | ||
| if (description != IntPtr.Zero) | ||
| { | ||
| to.Append(Runtime.GetManagedString(description)); |
There was a problem hiding this comment.
If GetManagedString fails, you leak description
Sorry, something went wrong.
There was a problem hiding this comment.
Ah, but I see that is not your doing but was already in the code...
Sorry, something went wrong.
There was a problem hiding this comment.
@filmor it is still my doing :-D
Sorry, something went wrong.
…tails (pythonnet#1143) Similar to pythonnet#900, but for constructors (reuses the same code) Related issues: pythonnet#811, pythonnet#265, pythonnet#1116
Similar to #900, but for constructors (reuses the same code moved around)
What does this implement/fix? Explain your changes.
This adds more details to "No constructor matches given arguments" message.
Was
Now
Does this close any currently open issues?
Does not close any issue, but is related to: #811, #265, #1116