FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Drop Python 2 support by filmor · Pull Request #1158 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Drop Python 2 support - #1158

Merged
lostmsu merged 8 commits into
pythonnet:masterfrom
filmor:drop-python2
Jun 20, 2020
ConversationCommits (8)ChecksFiles changed
Merged

Drop Python 2 support#1158
lostmsu merged 8 commits into
pythonnet:masterfrom
filmor:drop-python2

Conversation

filmor commented Jun 14, 2020

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

Drops support for and all references to Python 2.

Does this close any currently open issues?

Can't find it right now, but I think we had an issue discussing this.

Any other comments?

-/-

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

koubaa reviewed Jun 19, 2020
View reviewed changes
Comment thread src/runtime/runtime.cs
// We needs to replace all public constants to static readonly fields to allow
// binary substitution of different Python.Runtime.dll builds in a target application.

public static string pyversion => _pyversion;

koubaa Jun 19, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@filmor I think a unit test depends on these public properties

filmor Jun 19, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Which one? I was used in a few places, but only to check for Python 2 vs 3.

koubaa Jun 19, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@filmor you already removed them actually from TestPythonEngineProperties.cs
Seems like this might require an entry in the changelog since its a breaking change technically

filmor Jun 19, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, I could do that, but pyversion etc. where never really consumables in the first place. I'd like to move the whole Runtime to internal as a single Changelog entry, no need to do this for every single component.

lostmsu Jun 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@filmor moving Runtime to internal deserves its own tracking issue.

filmor Jun 19, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agreed: #1167

koubaa commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

@filmor have you tried just changing the runtime and leaving the tests as-is for a first pass? I looked through the runtime and didn't see a mistake so I think I would start by ruling out problems with the test updating (which can easily be done in a followon branch)

filmor commented Jun 19, 2020

Copy link
Copy Markdown
Member Author

Not needed. The failures before were due to one place where I forgot to replace text_type by str and instead removed it entirely, so instead repr was called which was buggy at the time. I fixed that (and a few other missing replacements of long and a missing import of operator) and now tests are passing. I'm not a big fan of doing multiple PRs for the same "change".

codecov-commenter commented Jun 19, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1158 into master will decrease coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1158      +/-   ##
==========================================
- Coverage   86.53%   86.25%   -0.28%     
==========================================
  Files           1        1              
  Lines         297      291       -6     
==========================================
- Hits          257      251       -6     
  Misses         40       40
Flag Coverage Δ
#setup_linux 64.94% <60.00%> (-0.04%) ⬇️
#setup_windows 72.50% <100.00%> (+0.45%) ⬆️
Impacted Files Coverage Δ
setup.py 86.25% <100.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 140a9b8...cc4211c. Read the comment docs.

koubaa reviewed Jun 19, 2020
View reviewed changes
Comment thread setup.py
lostmsu reviewed Jun 19, 2020
View reviewed changes

lostmsu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OK by me after a couple minor fixes

Comment thread src/runtime/runtime.cs
// We needs to replace all public constants to static readonly fields to allow
// binary substitution of different Python.Runtime.dll builds in a target application.

public static string pyversion => _pyversion;

lostmsu Jun 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@filmor moving Runtime to internal deserves its own tracking issue.

Comment thread src/tests/test_exceptions.py Outdated
Comment thread src/tests/_compat.py Outdated

lostmsu commented Jun 19, 2020

Copy link
Copy Markdown
Member

Also, if you don't increase the coverage back to the target, or lower the target a bit, it is going to complain on every subsequent PR.

filmor commented Jun 19, 2020

Copy link
Copy Markdown
Member Author

The coverage is always against master, it will not repeatedly complain.

lostmsu self-requested a review June 20, 2020 00:42
lostmsu merged commit ec424bb into pythonnet:master Jun 20, 2020
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 29, 2020
Drop Python 2 support (pythonnet#1158)
d38f864 
Drop Python 2 support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lostmsu lostmsu approved these changes
+1 more reviewer
koubaa koubaa left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

filmor

lostmsu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL