FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove unnecessary `CheckExceptionOccurred` calls by amos402 · Pull Request #1175 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Remove unnecessary CheckExceptionOccurred calls - #1175

Merged
filmor merged 11 commits into
pythonnet:masterfrom
amos402:remove-redundant-calls
Aug 15, 2020
ConversationCommits (11)ChecksFiles changed
Merged

Remove unnecessary CheckExceptionOccurred calls#1175
filmor merged 11 commits into
pythonnet:masterfrom
amos402:remove-redundant-calls

Conversation

amos402 commented Jul 2, 2020

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

Fro saving unnecessary costs.

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

dnfadmin commented Jul 2, 2020 •
edited
Loading

Copy link
Copy Markdown


All CLA requirements met.

codecov-commenter commented Jul 2, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1175 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1175   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          251      251           
  Misses         40       40
Flag Coverage Δ
#setup_linux 64.94% <ø> (ø)
#setup_windows 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2b297...8ca0a62. Read the comment docs.

lostmsu requested changes Jul 2, 2020
View reviewed changes
Comment thread src/runtime/NewReference.cs Outdated
Comment thread src/runtime/pythonexception.cs Outdated
Comment thread src/runtime/converter.cs Outdated
}
double dd = Runtime.PyFloat_AsDouble(op);
Runtime.CheckExceptionOccurred();
if (dd == -1.0)

lostmsu Jul 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Knowing the funny behavior of floating-point comparisons, it would be good to have two test cases for this conversion passing and failing.

filmor reviewed Jul 30, 2020
View reviewed changes
Comment thread appveyor.yml Outdated
install:
- python -m pip install -U pip
- pip install --upgrade -r requirements.txt --quiet
- pip install install pycparser --quiet

filmor Jul 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks wrong.

amos402 Jul 30, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, apparently it's wrong, never thought it works.😂
This line is due to requirements.txt declared won't pycparser be install on windows, but setup process need it.

lostmsu commented Jul 30, 2020

Copy link
Copy Markdown
Member

I'd prefer the --no-index part to be a separate PR

amos402 commented Aug 10, 2020

Copy link
Copy Markdown
Member Author

I'd prefer the --no-index part to be a separate PR

#1200

filmor merged commit 3e1fc2e into pythonnet:master Aug 15, 2020
amos402 deleted the remove-redundant-calls branch August 19, 2020 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor filmor left review comments
lostmsu lostmsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL