FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Pybuffer by koubaa · Pull Request #1195 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Pybuffer - #1195

Merged
lostmsu merged 8 commits into
pythonnet:masterfrom
koubaa:pybuffer
Aug 7, 2020
ConversationCommits (8)ChecksFiles changed
Merged

Pybuffer#1195
lostmsu merged 8 commits into
pythonnet:masterfrom
koubaa:pybuffer

Conversation

koubaa commented Aug 1, 2020

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Rebase of https://github.com/pythonnet/pythonnet/pull/980/files
...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

koubaa commented Aug 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@filmor I took this one. After rebasing I just had to bring back a property on the runtime which we removed. It used to be public but I brought it back as internal.

codecov-commenter commented Aug 1, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1195 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1195   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          251      251           
  Misses         40       40
Flag Coverage Δ
#setup_linux 64.94% <ø> (ø)
#setup_windows 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72a16d...0ed417c. Read the comment docs.

filmor reviewed Aug 1, 2020
View reviewed changes
Comment thread src/runtime/runtime.cs Outdated
//"3.0a5+ (py3k:63103M, May 12 2008, 00:53:55) \n[GCC 4.2.3]"

//we only support python 3 so we just need to check the third character
return 30 + Convert.ToInt32(versionString[2]);

filmor Aug 1, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This seems very brittle to me, there must be a better solution. Also, we don't support any Python version before 3.5, so checks for that can go.

koubaa Aug 1, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@filmor I could use sys.version_info but I'd rather not run python code. Let me look for a C API equivalent

koubaa Aug 1, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@filmor see now

lostmsu requested changes Aug 2, 2020
View reviewed changes
Comment thread src/runtime/runtime.cs Outdated

koubaa commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

@lostmsu please review

lostmsu requested changes Aug 4, 2020
View reviewed changes
Comment thread src/runtime/pybuffer.cs Outdated
lostmsu merged commit 8e029ef into pythonnet:master Aug 7, 2020
lostmsu mentioned this pull request Aug 25, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor filmor left review comments
lostmsu lostmsu requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL