Allow creating new .NET arrays from Python using Array[T](dim1, dim2,…) syntax - #1291
Merged
lostmsu merged 1 commit intoNov 24, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lostmsu
force-pushed
the
features/ArrayFromShape
branch
from
46e7c65 to
96cee3e
Compare
November 24, 2020 04:10
lostmsu
force-pushed
the
features/ArrayFromShape
branch
from
96cee3e to
1d17421
Compare
November 24, 2020 04:11
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
=======================================
Coverage 87.97% 87.97%
=======================================
Files 1 1
Lines 291 291
=======================================
Hits 256 256
Misses 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sorry, something went wrong.
filmor
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This handles a few new argument combinations in tp_new of .NET array types:
It processes all exceptions specified in https://docs.microsoft.com/en-us/dotnet/api/system.array.createinstance?view=net-5.0#System_Array_CreateInstance_System_Type_System_Int64___
Does this close any currently open issues?
fixes #251
Checklist
Check all those that are applicable and complete.