FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added github actions workflow to replace travis by lostmsu · Pull Request #1307 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Added github actions workflow to replace travis - #1307

Merged
filmor merged 2 commits into
pythonnet:masterfrom
losttech:travis-github
Dec 9, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Added github actions workflow to replace travis#1307
filmor merged 2 commits into
pythonnet:masterfrom
losttech:travis-github

Conversation

lostmsu commented Dec 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Subj

This drops coverage for setup.py

lostmsu force-pushed the travis-github branch 13 times, most recently from 92dcfd5 to bc4585c Compare December 8, 2020 05:56

lostmsu commented Dec 8, 2020

Copy link
Copy Markdown
Member Author

Either we:

  1. make our own docker images to test on (not sure how this works)
  2. have the build take 6+ minutes instead of 1 (remove Mono 6.12 and reinstall 5.20 instead)
  3. or switch Mono to 6.12 for testing

Considering we are doing a major version bump, we can pick option 3 for simplicity. @filmor thoughts?

lostmsu force-pushed the travis-github branch 2 times, most recently from 9db68a2 to 5379f53 Compare December 8, 2020 06:09

filmor commented Dec 8, 2020

Copy link
Copy Markdown
Member

I'm in favour of just using the latest version.

lostmsu mentioned this pull request Dec 8, 2020
Merged
4 tasks

codecov-io commented Dec 8, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1307 (d47d388) into master (5b09ba6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
  Coverage   74.04%   74.04%           
=======================================
  Files           1        1           
  Lines         289      289           
=======================================
  Hits          214      214           
  Misses         75       75
Flag Coverage Δ
setup_windows 74.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b09ba6...d47d388. Read the comment docs.

lostmsu requested a review from filmor December 9, 2020 00:53
filmor merged commit f8c27a1 into pythonnet:master Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor Awaiting requested review from filmor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL