PyIter: do not force dispose previous object upon moving to the next one - #1331
Merged
filmor merged 1 commit intoDec 18, 2020
Merged
PyIter: do not force dispose previous object upon moving to the next one#1331filmor merged 1 commit into
filmor merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
filmor
reviewed
Dec 18, 2020
Comment thread
src/runtime/runtime.cs
| @@ -1855,6 +1855,8 @@ internal static bool PyIter_Check(IntPtr pointer) | |||
|
|
|||
| [DllImport(_PythonDll, CallingConvention = CallingConvention.Cdecl)] | |||
| internal static extern IntPtr PyIter_Next(IntPtr pointer); | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Do we still need this?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Yes, there are still a few uses.
Sorry, something went wrong.
also added exception handling for PyIter_Next PyObject now implements `IEnumerable<PyObject>`
filmor
approved these changes
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Prior to this change trying to use object returned by iterating over PyObject would fail after iterator is closed, because iterator would dispose previously returned objects on close/moving to the next one.
This also adds error handling for PyIter_Next calls, which can have other reasons to fail beyond reaching the end of collection.
Checklist
Check all those that are applicable and complete.