Fix exception string - #1360
Merged
filmor merged 4 commits intoJan 29, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lostmsu
reviewed
Jan 21, 2021
Comment thread
src/runtime/pythonexception.cs
Ensure that the stacktrace list is joined into a single string and adjust the formatting slightly such that the .NET stacktrace is separated from the one from Python. Fixes pythonnet#1359.
filmor
force-pushed
the
fix-exception-string
branch
from
9811437 to
ce61a6f
Compare
January 29, 2021 06:45
Copy link
Copy Markdown
Contributor
|
That was quick, thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes #1359 by joining the traceback lines and separates the .NET stacktrace by an additional line.
Does this close any currently open issues?
#1359
Any other comments?
...
Checklist
Check all those that are applicable and complete.