Simplify PyScope by delegating ownership to PyObject instance - #1367
Merged
lostmsu merged 1 commit intoFeb 18, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Dang :( |
Sorry, something went wrong.
lostmsu
force-pushed
the
bugs/DomainReloadTest-UbuntuPy3.9-Workaround
branch
from
d8abce6 to
eebfe65
Compare
February 18, 2021 20:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
I noticed PyScope ownership implementation is so-so. One of the potential reasons for the crash could be PyScope being improperly deallocated.
This is an attempt to fix crash in CI on Ubuntu with Python 3.9.
Does this close any currently open issues?
No