FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Monthly NuGet release previews by lostmsu · Pull Request #1381 · pythonnet/pythonnet · GitHub

Monthly NuGet release previews - #1381

Merged
filmor merged 1 commit into
masterfrom
PR/NuGetMonthly
Feb 12, 2021
Merged

Monthly NuGet release previews#1381
filmor merged 1 commit into
masterfrom
PR/NuGetMonthly

Conversation

lostmsu commented Feb 11, 2021

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

This generates monthly release previews on NuGet using GitHub actions

Does this close any currently open issues?

#1379

lostmsu commented Feb 12, 2021

Copy link
Copy Markdown
Member Author

Passed, and published https://www.nuget.org/packages/pythonnet/3.0.0-preview21-02-12

I've updated trigger to schedule.

Comment thread .github/workflows/nuget-preview.yml Outdated
Comment thread .github/workflows/nuget-preview.yml Outdated
Comment thread .editorconfig Outdated

gpetrou commented Feb 12, 2021

Copy link
Copy Markdown
Contributor

Would it be possible to also use SignAssembly and AssemblyOriginatorKeyFile for StrongName support?

lostmsu commented Feb 12, 2021

Copy link
Copy Markdown
Member Author

@gpetrou you're welcome to contribute that. @filmor do we sign current releases? Where's the key?

filmor commented Feb 12, 2021

Copy link
Copy Markdown
Member

If there is a key, I don't have it. I don't really see what kind of trust we'd establish anyway, being essentially random internet people :)

lostmsu commented Feb 12, 2021

Copy link
Copy Markdown
Member Author

@filmor I am assuming they need strong name singing to be able to sign their own libraries, that use ours.

P.S. all open source projects are essentially "random internet people"

lostmsu commented Feb 12, 2021

Copy link
Copy Markdown
Member Author

@gpetrou if you really need signed releases, you are welcome to contribute support for that.

filmor merged commit 6b2347a into master Feb 12, 2021
filmor deleted the PR/NuGetMonthly branch February 12, 2021 21:36

gpetrou commented Feb 13, 2021
edited
Loading

Copy link
Copy Markdown
Contributor

I have created #1382.
There is already a key in the repository and an associated issue.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL