Repository navigation
Finalizer Fixes - #1383
Closed
filmor wants to merge 2 commits into
Closed
Finalizer Fixes#1383filmor wants to merge 2 commits into
filmor wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
filmor
force-pushed
the
finalizer-fixes
branch
from
4a783fa to
2b2c31c
Compare
February 22, 2021 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
During the implementation of #1373, a couple of errors surfaced when activating a proper shutdown. This PR tries to improve the situation such that finally, we can unconditionally activate the proper shutdown.
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.