Remove Utf8Marshaler, set PyScope base class to PyObject, added PyModule - #1391
Merged
filmor merged 4 commits intoFeb 26, 2021
Merged
Remove Utf8Marshaler, set PyScope base class to PyObject, added PyModule#1391filmor merged 4 commits into
filmor merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lostmsu
force-pushed
the
cleanup/21-02-19
branch
12 times, most recently
from
cbfd65c to
ad5343d
Compare
February 21, 2021 06:14
filmor
reviewed
Feb 22, 2021
Comment thread
src/runtime/pymodule.cs
filmor
reviewed
Feb 22, 2021
Comment thread
src/runtime/pythonengine.cs
filmor
reviewed
Feb 22, 2021
Comment thread
src/runtime/pythonengine.cs
Outdated
filmor
reviewed
Feb 22, 2021
Comment thread
src/runtime/tricks/NullOnly.cs
lostmsu
force-pushed
the
cleanup/21-02-19
branch
from
ad5343d to
86a4081
Compare
February 24, 2021 07:25
filmor
reviewed
Feb 24, 2021
Comment thread
src/runtime/pythonengine.cs
Outdated
| } | ||
|
|
||
| [Obsolete("Use PyModule.Import")] | ||
| public static PyObject Import(string name) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I wouldn't obsolete this one right now. Having Py. as a central entry-point has merit.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
@filmor Perhaps we should move Py class into its own file 🤣
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
:D
Yep, sorry for the inconsistency. I'd like to obsolete PythonEngine for the most part and collect entry points in Py.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Removed this [Obsolete], added a new issue to move Py out.
Sorry, something went wrong.
changed PyScope to inherit from PyObject
lostmsu
force-pushed
the
cleanup/21-02-19
branch
from
86a4081 to
ac68aab
Compare
February 24, 2021 18:10
lostmsu
force-pushed
the
cleanup/21-02-19
branch
from
08609b9 to
ac68aab
Compare
February 26, 2021 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also allow BorrowedReference == null comparison.