Allow GIL state debugging; require GILState to be properly disposed - #1397
Merged
lostmsu merged 1 commit intoMar 10, 2021
Merged
Allow GIL state debugging; require GILState to be properly disposed#1397lostmsu merged 1 commit into
lostmsu merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Is there any particular reason why we shouldn't just do this unconditionally? |
Sorry, something went wrong.
filmor
approved these changes
Mar 10, 2021
Copy link
Copy Markdown
Member
Author
|
I am concerned about performance. Once we get perf tests back online, I'd compare. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
PyGILState_Release must always be called from the same thread, that called PyGILState_Acquire. Which means it is illegal to try to dispose GILState from .NET finalizer thread.
See the following thread #1389 (comment)