Fixed __cause__ on overload bind failure and array conversion - #1442
Conversation
Sorry, something went wrong.
|
As there are probably a few more places like this, shouldn't we add a convenience IDisposable that does the fetching in startup and restores on Dispose? |
Sorry, something went wrong.
|
@filmor I do not think it is justified at this moment: with just these two places I don't get any more related assertion failures of that nature with debug builds of Python throughout out test suite. |
Sorry, something went wrong.
| } | ||
|
|
||
| value.Append(": "); | ||
| Runtime.PyErr_Fetch(out var errType, out var errVal, out var errTrace); |
There was a problem hiding this comment.
This might also be a fix for #1371
Sorry, something went wrong.
There was a problem hiding this comment.
It might let us reenable the test case, but the issue that caused it will still be there.
Sorry, something went wrong.
BadSingleton
left a comment
There was a problem hiding this comment.
LGTM. However this is something easy to miss. It'd be great if we had pythonnet in debug (without Py_Debug) be able to detect known cases.
Sorry, something went wrong.
also: added debug check
What does this implement/fix? Explain your changes.
Calls to PyObject_Str and PyObject_Repr should not be made with error set, as they may clear it. When using debug build of Python, this causes an assertion at runtime, preventing use of Python.NET.
Does this close any currently open issues?
Partial fix for #1412