FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle ProcessExit event by lostmsu · Pull Request #1458 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Handle ProcessExit event - #1458

Merged
lostmsu merged 1 commit into
pythonnet:masterfrom
losttech:bugs/PyCrashOnExit
May 29, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Handle ProcessExit event#1458
lostmsu merged 1 commit into
pythonnet:masterfrom
losttech:bugs/PyCrashOnExit

Conversation

lostmsu commented May 21, 2021

Copy link
Copy Markdown
Member

This avoids segfault when CLR (in particular Mono) is unloaded before Python stops.

What does this implement/fix? Explain your changes.

  1. Added a handler to AppDomain.ProcessExit, that fires in the situations like this instead of AppDomain.DomainUnload. This allows Python.NET to remove all slots, that are implemented in C#.
  2. When initialized as extension (e.g. Python hosts CLR), release GIL acquired during shutdown so that Python finalization can resume.

Does this close any currently open issues?

This is (at least one of) the reason of CI test crashes in #1134

filmor reviewed May 22, 2021
View reviewed changes
Comment thread src/runtime/runtime.cs
}
else
{
PyGILState_Release(state);

filmor May 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This change seems unrelated, why did you add this?

lostmsu May 22, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Without this Py_Finalize called when Python finally shuts down hangs because it can't acquire GIL.

lostmsu commented May 22, 2021

Copy link
Copy Markdown
Member Author

I debugged the test failures, and they appear to be caused by gaps in domain reload support: when .NET objects that Python sees get severed from CLR, subsequent calls to their tp_dealloc fail because GetManagedObject returns null.

lostmsu force-pushed the bugs/PyCrashOnExit branch from 914ff18 to 366f548 Compare May 23, 2021 07:42

lostmsu commented May 23, 2021

Copy link
Copy Markdown
Member Author

Found a way to solve the same problem and more without handling ProcessExit

lostmsu closed this May 23, 2021

lostmsu commented May 29, 2021

Copy link
Copy Markdown
Member Author

Or maybe not. Seems to still be essential for #1134

lostmsu reopened this May 29, 2021
lostmsu requested a review from filmor May 29, 2021 23:10
lostmsu merged commit 7eac886 into pythonnet:master May 29, 2021
lostmsu deleted the bugs/PyCrashOnExit branch May 29, 2021 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor Awaiting requested review from filmor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL