Fixed crash in ToArray when sequence explicitly denies __len__ - #1484
Merged
filmor merged 1 commit intoJul 7, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lostmsu
force-pushed
the
Mini/NoCrashWhenSequenceLengthUndefined
branch
from
f02f565 to
41474f1
Compare
July 7, 2021 00:44
lostmsu
force-pushed
the
Mini/NoCrashWhenSequenceLengthUndefined
branch
from
41474f1 to
b52823b
Compare
July 7, 2021 00:46
filmor
approved these changes
Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port of 8e1d4db
What does this implement/fix? Explain your changes.
Prevents crash on converting sequences to arrays when sequence lacks __len__.
Sequence types might return error from PySequence_Size (like sequences provided by generators or types implemented in C, that lack sq_length slot or make it throw). This change adds handling for this case.