FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed double call to `PyType_Ready` in CLR MetaType's `tp_new` by lostmsu · Pull Request #1486 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Fixed double call to PyType_Ready in CLR MetaType's tp_new #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filmor merged 1 commit into from
Jul 7, 2021
Conversation 0 Commits 1 Checks 0 Files changed
Merged

Fixed double call to PyType_Ready in CLR MetaType's tp_new #1486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .cs  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
7 changes: 4 additions & 3 deletions src/runtime/metatype.cs
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ public static IntPtr tp_new(IntPtr tp, IntPtr args, IntPtr kw)
return IntPtr.Zero;
}

var flags = TypeFlags.Default;
var flags = (TypeFlags)Util.ReadCLong(type, TypeOffset.tp_flags);
if (!flags.HasFlag(TypeFlags.Ready))
throw new NotSupportedException("PyType.tp_new returned an incomplete type");
flags |= TypeFlags.HasClrInstance;
flags |= TypeFlags.HeapType;
flags |= TypeFlags.BaseType;
Expand All @@ -170,8 +172,7 @@ public static IntPtr tp_new(IntPtr tp, IntPtr args, IntPtr kw)
IntPtr gc = Marshal.ReadIntPtr(base_type, Offsets.tp_clr_inst);
Marshal.WriteIntPtr(type, Offsets.tp_clr_inst, gc);

if (Runtime.PyType_Ready(type) != 0)
throw PythonException.ThrowLastAsClrException();
Runtime.PyType_Modified(new BorrowedReference(type));

return type;
}
Expand Down
Back | FazBrowse Home | New Git URL