Implements buffer interface for .NET arrays of primitive types - #1511
Merged
filmor merged 1 commit intoSep 3, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lostmsu
force-pushed
the
array-buffer-interface
branch
from
c2dff5d to
00aed52
Compare
August 25, 2021 19:34
filmor
reviewed
Aug 25, 2021
Comment thread
src/embed_tests/NumPyTests.cs
| try { | ||
| np = Py.Import("numpy"); | ||
| } catch (PythonException) { | ||
| Assert.Inconclusive("Numpy or dependency not installed"); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We should probably make that numpy is installed in our CI then, no?
Sorry, something went wrong.
filmor
reviewed
Aug 25, 2021
Comment thread
src/runtime/arrayobject.cs
Outdated
filmor
reviewed
Aug 25, 2021
Comment thread
src/runtime/arrayobject.cs
Outdated
lostmsu
force-pushed
the
array-buffer-interface
branch
from
00aed52 to
5e5ffff
Compare
August 25, 2021 21:15
Copy link
Copy Markdown
Member
Author
|
Added pip install numpy for testing. For buffer formats see pybind/pybind11#1908 (comment) (also added code comment) |
Sorry, something went wrong.
lostmsu
force-pushed
the
array-buffer-interface
branch
2 times, most recently
from
6e1f0a8 to
91de771
Compare
August 28, 2021 16:35
lostmsu
force-pushed
the
array-buffer-interface
branch
from
91de771 to
dc9172a
Compare
August 28, 2021 16:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This allows Python libraries such as NumPy efficiently copy data to/from .NET arrays.
Checklist
Check all those that are applicable and complete.