Cleaning up public API - #1557
Merged
lostmsu merged 1 commit intoSep 30, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lostmsu
force-pushed
the
public-API-cleanup
branch
7 times, most recently
from
17b4a04 to
550fcaf
Compare
September 21, 2021 18:30
lostmsu
force-pushed
the
public-API-cleanup
branch
from
550fcaf to
1a2ad6d
Compare
September 23, 2021 16:54
filmor
reviewed
Sep 24, 2021
Comment thread
src/embed_tests/TestRuntime.cs
filmor
reviewed
Sep 30, 2021
Comment thread
src/runtime/delegatemanager.cs
| Type[] args = { ptrtype, typetype }; | ||
| ConstructorBuilder cb = tb.DefineConstructor(ma, cc, args); | ||
| ConstructorInfo ci = basetype.GetConstructor(args); | ||
| ConstructorInfo ci = basetype.GetConstructor(BindingFlags.Instance | BindingFlags.NonPublic, null, args, null); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Does this change behaviour?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Users can no longer construct their own instances of Dispatcher manually (which is the goal of the change).
I doubt anyone did that anyway, it is very obscure.
Sorry, something went wrong.
filmor
approved these changes
Sep 30, 2021
lostmsu
force-pushed
the
public-API-cleanup
branch
from
1a2ad6d to
392537a
Compare
September 30, 2021 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles #1539
Deleted:
Checklist
Check all those that are applicable and complete.