Disable implicit conversions that might lose information - #1568
Merged
lostmsu merged 3 commits intoSep 27, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lostmsu
force-pushed
the
disable-auto-conversions
branch
from
631b019 to
c97e5ab
Compare
September 23, 2021 19:05
lostmsu
marked this pull request as ready for review
September 23, 2021 20:43
filmor
approved these changes
Sep 24, 2021
Comment thread
tests/test_conversion.py
PyInt -> int32 .NET arrays and collections -> Python list (due to mutability)
lostmsu
force-pushed
the
disable-auto-conversions
branch
from
2e8cd3f to
b2e6d4e
Compare
September 27, 2021 21:45
lostmsu
commented
Sep 27, 2021
lostmsu
left a comment
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
A few minor isssues
Sorry, something went wrong.
Comment thread
src/runtime/converter.cs
| { | ||
| if (setError) | ||
| { | ||
| Exceptions.SetError(ex.InnerException); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Should be just SetError(ex)
Sorry, something went wrong.
Comment thread
src/runtime/converter.cs
Comment on lines
363
to
364
| return true; | ||
| } | ||
| // shouldn't happen | ||
| return false; | ||
| } |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Fallback branch should be added.
Sorry, something went wrong.
lostmsu
added a commit
to losttech/pythonnet
that referenced
this pull request
Sep 27, 2021
lostmsu
added a commit
to losttech/pythonnet
that referenced
this pull request
Sep 27, 2021
lostmsu
added a commit
that referenced
this pull request
Sep 27, 2021
lostmsu
added a commit
to losttech/pythonnet
that referenced
this pull request
Oct 2, 2021
… point types arbitrary Python objects are no longer implicitly converted to .NET bool type this is a continuation of pythonnet#1568
3 tasks
lostmsu
added a commit
to losttech/pythonnet
that referenced
this pull request
Oct 2, 2021
… point types arbitrary Python objects are no longer implicitly converted to .NET bool type this is a continuation of pythonnet#1568
lostmsu
added a commit
to losttech/pythonnet
that referenced
this pull request
Oct 2, 2021
… point types arbitrary Python objects are no longer implicitly converted to .NET bool type this is a continuation of pythonnet#1568
lostmsu
added a commit
to losttech/pythonnet
that referenced
this pull request
Oct 2, 2021
… point types arbitrary Python objects are no longer implicitly converted to .NET bool type this is a continuation of pythonnet#1568
lostmsu
added a commit
to losttech/pythonnet
that referenced
this pull request
Oct 2, 2021
… point types arbitrary Python objects are no longer implicitly converted to .NET bool type this is a continuation of pythonnet#1568
lostmsu
added a commit
that referenced
this pull request
Oct 5, 2021
… point types arbitrary Python objects are no longer implicitly converted to .NET bool type this is a continuation of #1568
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This removes the following conversions:
PyInt -> int32 (when trying to convert to object only)
.NET arrays and collections -> Python list (due to mutability)
Additionally, PyObject no longer implements IEnumerable<PyObject>, as not all python objects are iterable. Instead, a new class PyIterable is added.
Checklist