Fix string construction - #1862
Merged
filmor merged 1 commit intoJul 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
filmor
force-pushed
the
fix-string-construction
branch
from
cdfedf1 to
24e5c7e
Compare
July 9, 2022 22:39
filmor
force-pushed
the
fix-string-construction
branch
from
24e5c7e to
808fb0a
Compare
July 11, 2022 14:16
filmor
marked this pull request as ready for review
July 11, 2022 14:17
5 tasks
This was referenced Sep 16, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Since .NET strings are currently treated as "primitive" types (as they can not be constructed uninitialised, like other non-primitive types can), we only provide the "simple" constructor that converts a Python string or copies an existing String instance.
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.