Fixed use of the process handle after Process instance is garbage collected - #1940
Merged
filmor merged 1 commit intoSep 16, 2022
Merged
Fixed use of the process handle after Process instance is garbage collected#1940filmor merged 1 commit into
filmor merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Sep 16, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Current process handle can be closed before we try to enumerate process modules because we do not keep an instance of Process alive.
Does this close any currently open issues?
fixes #1939
Any other comments?
credits to @sdao for discovering the bug and suggesting a fix