Delete target object from event handler collections when it has no more event handlers - #1973
Merged
filmor merged 3 commits intoOct 14, 2022
Merged
Delete target object from event handler collections when it has no more event handlers#1973filmor merged 3 commits into
filmor merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The objects were leaking because they were kept as keys in a dictionary, that stored event handlers corresponding to object.
This change ensures that when the last handler is removed from an object, the object is removed from that dictionary.
Does this close any currently open issues?
fixes #1972
Checklist
Check all those that are applicable and complete.