1990 py int to string fix - #1991
Closed
rmadsen-ks wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Added a unit test to show a problem with String.Format / PyInt.ToString()
There was an issue with values between 128 and 256, possibly because of some bug inside BigInteger, which I did not fully understand. Anyway, it seems that a simpler solution is to just use LongInteger when possible.
Copy link
Copy Markdown
Member
|
It looks like the issue is actually in ToBigInteger? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1990: PyInt.ToString() has wrong results for values between 128 and 255
Check all those that are applicable and complete.