Object identity, Interfaces and Attributes by rmadsen-ks · Pull Request #2019 · pythonnet/pythonnet · GitHub

This PR contains multiple improvements:

All classes inheriting from a .net class has their own .net type. This means they can be returned and given as arguments without loosing their original identity (and properties).
Interfaces can be implemented. Also classes only inheriting interfaces are supported.
Attributes can be used in multiple different flavors.
- Class attributes using e.g @attribute(Browsable(False)), or clr_attributes = [Browsable(False), ...]
- Method attributes for methods exported to .NET.
```
    @attribute(DisplayName("X"))
    @method()
    def X(self):
          pass
```
- Property attributes using property(Double,0.0).add_attribute(DisplayName("X")

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Ensure you have signed the .NET Foundation CLA
Add yourself to AUTHORS
Updated the CHANGELOG

Added a unit test which consists ofa python class inheriting from a C# class which has a virtual generic method. In this version, this causes a InvalidProgramException to be thrown during class creation.

Previously an exception was thrown during class creation if the python class inherited from a class with a virtual generic method. This has been fixed by ignoring generic methods when creating overloads in the generated class. Note, this means that generic virtual methods cannot be overridden in python code.

- Changed the behavior so that a .NET is always created when the base type is also a .NET type.

- Added shortened Attribute aliases which just generates tuples. - More general CLR base class support - creating a class instance from C# is now more similar to creating one from python. - Added attribute decorator to clr.py. - Added testing for the various possibilities

- Fixed search bug in AssocAttribute - Added testing

…attribute.

… inside a .NET module.

Added support for specifying attributes on property-methods (eg. get/set attributes).

…eritGenericVirtualMethodFix2

Added a few cleanups and comments.

Can't introduce breaking changes

clean up the history

This XML doc does not have any useful information.

Please, split smaller fixes into individual PRs (e.g. #1776). I'd rather have #1774 also have its own PR as the code does not seem to be interdependent.

@lostmsu, ok, I understand. I just want to make sure you agree with the intentions here before I spend a lot of work trying to separate things out. What about the support for Attributes and interfaces? Are you ok with adding something like that?

Anyway, it sounds like you want #1774 implemented in a specific way? Maybe it is easier that it is not me who develops that then?

I'll try to take #1776 and create a separate PR for it.

First two parts: #2028, #2026

Superseded by smaller changes

rmadsen-ks added 15 commits October 31, 2022 15:32

1776 Inherit Generic Virtual Method Bug: Unit Test

ab531f8

Added a unit test which consists ofa python class inheriting from a C# class which has a virtual generic method. In this version, this causes a InvalidProgramException to be thrown during class creation.

1774-ClassWithoutnamespace

eb4ce37

- Changed the behavior so that a .NET is always created when the base type is also a .NET type.

better support for multiple inheritance

a2c80cd

Fixed issue with protected constructors and classes with no constructor

65c2c00

- Expanded the way attributes amy be added

014ef2e

- Fixed search bug in AssocAttribute - Added testing

added support for creating abstract classes using a __clr_abstract__ …

2449bd2

…attribute.

Improved AttributeError when looking for a symbol that does not exist…

7980fc4

… inside a .NET module.

Added test to detect an issue with object construction.

cf2c27a

Added support for marking properties with python types.

adc6613

Added support for specifying attributes on property-methods (eg. get/set attributes).

Fixed issue calling base-base class implementation of methods.

9373a03

Merged with Pythonnet 3.0 RC.6.

ab12481

Merge branch 'master' of github.com:pythonnet/pythonnet into 1776-Inh…

c290bf9

…eritGenericVirtualMethodFix2

Cleanup and comments

bb988cd

Added a few cleanups and comments.

rmadsen-ks mentioned this pull request Nov 18, 2022

Classes without __namespace__ cannot be used for reflection #1774

Open

lostmsu reviewed Nov 29, 2022

View reviewed changes

lostmsu closed this Apr 11, 2025

+                  /// <summary>
+                  /// Creates a new instance of PythonTypeAttribute.
+                  /// </summary>
+                  /// <param name="pyTypeModule"></param>
+                  /// <param name="pyTypeName"></param>

Object identity, Interfaces and Attributes by rmadsen-ks · Pull Request #2019 · pythonnet/pythonnet · GitHub

Uh oh!

Object identity, Interfaces and Attributes - #2019

Object identity, Interfaces and Attributes#2019
rmadsen-ks wants to merge 15 commits into
pythonnet:masterfrom
rmadsen-ks:1776-InheritGenericVirtualMethodFix2

rmadsen-ks commented Nov 18, 2022 •
edited
Loading

Uh oh!

Uh oh!

lostmsu Nov 29, 2022

Uh oh!

lostmsu Nov 29, 2022

Uh oh!

lostmsu Nov 29, 2022

Uh oh!

lostmsu commented Nov 29, 2022

Uh oh!

rmadsen-ks commented Nov 29, 2022

Uh oh!

rmadsen-ks commented Nov 29, 2022

Uh oh!

lostmsu commented Apr 11, 2025 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

+                                  if (!clsDict.HasKey("__namespace__"))
+                                  {
+                                      clsDict["__namespace__"] =
+                                          (clsDict["__module__"].ToString()).ToPython();
+                                  }

		Python.Runtime.Runtime.PythonDLL =
		"C:\\Python37.2\\python37.dll";

Object identity, Interfaces and Attributes by rmadsen-ks · Pull Request #2019 · pythonnet/pythonnet · GitHub

Uh oh!

Object identity, Interfaces and Attributes - #2019

Object identity, Interfaces and Attributes#2019rmadsen-ks wants to merge 15 commits intopythonnet:masterpythonnet/pythonnet:masterfrom rmadsen-ks:1776-InheritGenericVirtualMethodFix2rmadsen-ks/pythonnet:1776-InheritGenericVirtualMethodFix2Copy head branch name to clipboard

Conversation

rmadsen-ks commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lostmsu Nov 29, 2022

Choose a reason for hiding this comment

Uh oh!

lostmsu Nov 29, 2022

Choose a reason for hiding this comment

Uh oh!

lostmsu Nov 29, 2022

Choose a reason for hiding this comment

Uh oh!

lostmsu commented Nov 29, 2022

Uh oh!

rmadsen-ks commented Nov 29, 2022

Uh oh!

rmadsen-ks commented Nov 29, 2022

Uh oh!

lostmsu commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Object identity, Interfaces and Attributes#2019
rmadsen-ks wants to merge 15 commits into
pythonnet:masterfrom
rmadsen-ks:1776-InheritGenericVirtualMethodFix2

rmadsen-ks commented Nov 18, 2022 •
edited
Loading

lostmsu commented Apr 11, 2025 •
edited
Loading