FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ensure that `load` only runs once by filmor · Pull Request #2079 · pythonnet/pythonnet · GitHub

Ensure that load only runs once - #2079

Merged
filmor merged 1 commit into
masterfrom
filmor-patch-1
Jan 18, 2023
Merged

Ensure that load only runs once#2079
filmor merged 1 commit into
masterfrom
filmor-patch-1

Conversation

filmor commented Jan 17, 2023

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

Fixes an oversight in that _LOADED was never set in pythonnet.load.

Does this close any currently open issues?

#2078

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

filmor commented Jan 17, 2023

Copy link
Copy Markdown
Member Author

@lostmsu Could you have a look at what's going on on the ARM64 instance?

lostmsu commented Jan 17, 2023

Copy link
Copy Markdown
Member

Seems GTG. Rebase and ARM branch should pass. Do not rerun this and older commits in CI, as one of the setup steps breaks the environment by upgrading setuptools.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL