FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use msbuild tools from PATH if available by rnestler · Pull Request #208 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Use msbuild tools from PATH if available - #208

Merged
tonyroberts merged 1 commit into
pythonnet:masterfrom
rnestler:use_tools_in_path
Jun 23, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Use msbuild tools from PATH if available#208
tonyroberts merged 1 commit into
pythonnet:masterfrom
rnestler:use_tools_in_path

Conversation

rnestler commented Apr 20, 2016

Copy link
Copy Markdown
Contributor

While _find_msbuild_tool searches in the registry to find the given
build tool, it doesn't check if it's already in PATH.

If one uses a developer command prompt to build, all necessary tools are
in PATH.

Fixes #207 for me

den-run-ai commented Apr 20, 2016

Copy link
Copy Markdown
Contributor

related:

#194

tonyroberts reviewed Apr 20, 2016
View reviewed changes
Comment thread setup.py


def _find_msbuild_tool(tool="msbuild.exe", use_windows_sdk=False):
path = find_executable(tool)

tonyroberts Apr 20, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be below the docstring

rnestler Apr 20, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh my god how did that happen 😮 Silly me.

Use msbuild tools from PATH
35e3b28 
While _find_msbuild_tool searches in the registry to find the given
build tool, it doesn't check if it's already in PATH.

If one uses a developer command prompt to build, all necessary tools are
in PATH.

Fixes pythonnet#207 for me
rnestler force-pushed the use_tools_in_path branch from 3247415 to 35e3b28 Compare April 20, 2016 20:34

rnestler commented Apr 22, 2016

Copy link
Copy Markdown
Contributor Author

@denfromufa I fixed the docstring issue. Can this be merged or is something else missing?

den-run-ai commented Apr 22, 2016

Copy link
Copy Markdown
Contributor

@rnestler actually it is @tonyroberts who is merging pull requests for pythonnet. I'm ordinary contributor like you are :)

tonyroberts commented Apr 22, 2016

Copy link
Copy Markdown
Contributor

@rnestler looks fine - but the Appveyor CI tests aren't working right now, so I need to fix that before I can merge this PR.

rnestler commented Apr 26, 2016

Copy link
Copy Markdown
Contributor Author

@tonyroberts I activated AppVeyor CI on my fork. It seems to build fine there: https://ci.appveyor.com/project/rnestler/pythonnet/build/1.0.2

tonyroberts merged commit 72366c6 into pythonnet:master Jun 23, 2016
rnestler mentioned this pull request Jun 23, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL