Remove suggestions to use internal functions - #2092
Merged
filmor merged 2 commits intoJan 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lostmsu
reviewed
Jan 26, 2023
Comment thread
doc/source/dotnet.rst
Comment on lines
-50
to
-52
| When finished using Python APIs, managed code must call a corresponding | ||
| ``PythonEngine.ReleaseLock`` to release the GIL and allow other threads | ||
| to use Python. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
IMHO, "when finished" section needs corresponding replacement (maybe merged with the acquisition part).
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Better?
Sorry, something went wrong.
lostmsu
approved these changes
Jan 29, 2023
lostmsu
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I could see this being confusing a bit in regards with "disposing the return value" - as in "previously returned value" vs "call Py.GIL().Dispose() to release, but probably everyone would read it correctly.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2091.
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.