Fix GetBuffer throwing ArgumentOutOfRangeException - #2120
Merged
lostmsu merged 3 commits intoMar 12, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
filmor
approved these changes
Mar 11, 2023
Copy link
Copy Markdown
Member
|
NIT: add parameter names to Copy calls (e.g. length: ...). Would be easier to spot the mistake next time. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
PyBuffer throws System.ArgumentOutOfRangeException when trying to use GetBuffer() with anything other than PyBUF.SIMPLE since the Marshal.Copy calls had a typos so it was trying to copy shape, strides, and suboffsets as arrays that were the full length of the source array instead of length ndim.
Does this close any currently open issues?
no
Any other comments?
...
Checklist
Check all those that are applicable and complete.