Python 3.12 - #2249
Conversation
### Rationale for this change The conda-integration build has recently started failing: https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453 Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249). ### What changes are included in this PR? Avoid using Python 3.12 for Archery in conda-integration build. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: #37993 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
|
Please take the commit from https://github.com/losttech/pythonnet/tree/instanceless-explicit to change the test. If it still does not raise in 3.12, keep the version guard and refer to python/cpython#101578 |
Sorry, something went wrong.
|
Same result. It actually does raise, but the reference check for PyErr fails and it doesn't convert it. |
Sorry, something went wrong.
|
On Python 3.12 I think it should raise an instance of StopIteration. Prior to 3.12 that would be an exception with type StopIteration but without instance, which is what decoder was handling. E.g. if you replace the check for the wrapper with a check for StopIteration instance in 3.12, that should do it. |
Sorry, something went wrong.
|
Well, that's not what this one is testing, though. I'll keep it deactivated for now. If the rest is fine with you, I'll merge it and cut a new version (maybe after having another look at #2245). |
Sorry, something went wrong.
👍I can fix the test as I outlined above. My understanding is that 3.12 always normalizes exceptions while 3.11 and before did not. E.g. throw new PythonException(stopIteration, value: null, traceback: null) (and the original iteration over an empty list) would end up raising a Python error with type StopIteration and None value in 3.11 and before, while 3.12 will automatically call StopIteration constructor in this case and set exception value to the resulting instance. The decoder is needed in 3.11 and before because otherwise you have no way in C# to catch None exception value. |
Sorry, something went wrong.
### Rationale for this change The conda-integration build has recently started failing: https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453 Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249). ### What changes are included in this PR? Avoid using Python 3.12 for Archery in conda-integration build. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#37993 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
### Rationale for this change The conda-integration build has recently started failing: https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453 Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249). ### What changes are included in this PR? Avoid using Python 3.12 for Archery in conda-integration build. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#37993 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.