Repository navigation
Explicitly compare MaybeType objects by name - #2270
Closed
filmor wants to merge 1 commit into
Closed
filmor wants to merge 1 commit into
filmor wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
What I meet is a Unity Project with FingerGesture plugin |
Sorry, something went wrong.
filmor
force-pushed
the
compare-maybetype-by-name
branch
from
4195f16 to
4bb5e6b
Compare
October 18, 2023 13:53
Copy link
Copy Markdown
|
This is the test-case. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Do you know circumstances under which this happens? What is the scenario when we can have two different MaybeType with the same name? Perhaps this is what needs to be prevented instead. |
Sorry, something went wrong.
filmor
force-pushed
the
compare-maybetype-by-name
branch
2 times, most recently
from
536c341 to
bccee2c
Compare
September 19, 2024 18:05
filmor
force-pushed
the
compare-maybetype-by-name
branch
from
bccee2c to
daecf43
Compare
December 8, 2025 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
As observed by @rayfalling, multiple instances of ReflectedType values might be created in the cache, leading to crashes during stashing.
@rayfalling, could you provide a test-case for this?
Does this close any currently open issues?
#2269
Any other comments?
...
Checklist
Check all those that are applicable and complete.