Repository navigation
Try to be strict around non-copyability - #2440
filmor wants to merge 1 commit into
Conversation
Sorry, something went wrong.
| public double ToDouble() => Runtime.PyFloat_AsDouble(obj); | ||
|
|
||
| public override TypeCode GetTypeCode() => TypeCode.Double; | ||
| public override int GetHashCode() => ((PyObject)this).GetHashCode(); |
There was a problem hiding this comment.
This looks like it would just stackoverflow
Sorry, something went wrong.
| } | ||
|
|
||
| public override TypeCode GetTypeCode() => TypeCode.Int64; | ||
| public override int GetHashCode() => ((PyObject)this).GetHashCode(); |
There was a problem hiding this comment.
Same
Sorry, something went wrong.
| var free = (delegate* unmanaged[Cdecl]<ref StolenReference, void>)freePtr; | ||
| free(ref ob); |
There was a problem hiding this comment.
I think this is wrong. It does not say anywhere but I'd expect tp_free to take a reference to PyObject (e.g. PyObject*), not a reference to reference to it (e.g. not a PyObject**).
Sorry, something went wrong.
There was a problem hiding this comment.
Ah, that's probably one reason for the crashes :)
Sorry, something went wrong.
|
Seems abandoned - requested changes not addressed. |
Sorry, something went wrong.
|
Not abandoned, just very low priority. We have to fix these warnings eventually, they are extremely spammy and the non-copyability check is borderline useless right now. Either we fix things or we drop the analyzer until an official one is added. |
Sorry, something went wrong.
No description provided.