| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@jreback can you add a note how to build/install this? I did not find this in conda docs. |
Sorry, something went wrong.
|
sure where would you like the note? further this required conda-build for actually executing this (do you have a dev requirements list somewhere?) e.g. conda build conda.recipe --python 3.5 |
Sorry, something went wrong.
|
@jreback you can add the note in wiki - it is open to everyone: https://github.com/pythonnet/pythonnet/wiki/Installation We do not have requirements files yet, due to dependency on .NET/Mono tools and nuget. But I opened an issue for this, since it is a good idea anyway: I tried your instruction and it is failing badly on me with latest conda and conda-build. C:\Users\denis.akhiyarov\Downloads\pythonnet>cd pythonnet-clr-recipe\
C:\Users\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe>conda build co
nda.recipe --python 2.7
Cloning into bare repository 'C:\Python\Python27_32b\conda-bld\git_cache\C_\User
s\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe'...
fatal: 'C:\Users\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe' does
not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Cloning into bare repository 'C:\Python\Python27_32b\conda-bld\git_cache\C_\User
s\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe'...
fatal: 'C:\Users\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe' does
not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Warning: failed to download source. If building, will try again after downloadi
ng recipe dependencies.
Error was:
Command '['C:\\Users\\denis.akhiyarov\\AppData\\Local\\Atlassian\\SourceTree\\gi
t_local\\bin\\git.exe', 'clone', '--mirror', 'C:\\Users\\denis.akhiyarov\\Downlo
ads\\pythonnet\\pythonnet-clr-recipe', 'C:\\Python\\Python27_32b\\conda-bld\\git
_cache\\C_\\Users\\denis.akhiyarov\\Downloads\\pythonnet\\pythonnet-clr-recipe']
' returned non-zero exit status 128
BUILD START: clr--py27_0
(actual version deferred until further download or env creation)
updating index in: C:\Python\Python27_32b\conda-bld\win-32
updating index in: C:\Python\Python27_32b\conda-bld\noarch
The following NEW packages will be INSTALLED:
pip: 8.1.2-py27_0
python: 2.7.12-0
setuptools: 27.2.0-py27_1
vs2008_runtime: 9.00.30729.1-2
wheel: 0.29.0-py27_0
Cloning into bare repository 'C:\Python\Python27_32b\conda-bld\git_cache\C_\User
s\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe'...
fatal: 'C:\Users\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe' does
not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Cloning into bare repository 'C:\Python\Python27_32b\conda-bld\git_cache\C_\User
s\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe'...
fatal: 'C:\Users\denis.akhiyarov\Downloads\pythonnet\pythonnet-clr-recipe' does
not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Warning: failed to download source. If building, will try again after downloadi
ng recipe dependencies.
Error was:
Command '['C:\\Users\\denis.akhiyarov\\AppData\\Local\\Atlassian\\SourceTree\\gi
t_local\\bin\\git.exe', 'clone', '--mirror', 'C:\\Users\\denis.akhiyarov\\Downlo
ads\\pythonnet\\pythonnet-clr-recipe', 'C:\\Python\\Python27_32b\\conda-bld\\git
_cache\\C_\\Users\\denis.akhiyarov\\Downloads\\pythonnet\\pythonnet-clr-recipe']
' returned non-zero exit status 128
Traceback (most recent call last):
File "C:\Python\Python27_32b\Scripts\conda-build-script.py", line 5, in <modul
e>
sys.exit(conda_build.cli.main_build.main())
File "C:\Python\Python27_32b\lib\site-packages\conda_build\cli\main_build.py",
line 242, in main
execute(sys.argv[1:])
File "C:\Python\Python27_32b\lib\site-packages\conda_build\cli\main_build.py",
line 234, in execute
already_built=None, config=config)
File "C:\Python\Python27_32b\lib\site-packages\conda_build\api.py", line 77, i
n build
need_source_download=need_source_download, config=config)
File "C:\Python\Python27_32b\lib\site-packages\conda_build\build.py", line 109
9, in build_tree
config=recipe_config)
File "C:\Python\Python27_32b\lib\site-packages\conda_build\build.py", line 667
, in build
assert not need_source_download, "Source download failed. Please investigat
e."
AssertionError: Source download failed. Please investigate.
|
Sorry, something went wrong.
|
@denfromufa you need to be one level up and make sure this is in fact a git repository. This is not a source build as the version numbers need git. |
Sorry, something went wrong.
|
I downloaded your git branch from github and extracted it. Then I tried all C:\Users\denis.akhiyarov\Downloads\pythonnet>conda build C:\Users\denis.akhiyarov\Downloads\pythonnet>conda build On Thu, Nov 3, 2016 at 12:52 PM, Jeff Reback notifications@github.com
|
Sorry, something went wrong.
|
@denfromufa I doubt this actually works on 32bit. 64-bit only. |
Sorry, something went wrong.
|
@denfromufa ok give a try again, my recipe was totally messed up, was using some older stuff |
Sorry, something went wrong.
On Thu, Nov 3, 2016, 1:49 PM Jeff Reback notifications@github.com wrote:
|
Sorry, something went wrong.
|
do you agree to MIT license transition (ZPL 2.0 currently), can you keep pip-based builds (otherwise we need to keep 2 appveyor files), why is it only working on python 2.7? |
Sorry, something went wrong.
|
my change actually is working fine |
Sorry, something went wrong.
|
@jreback oh I see one instance like this with pip 9.0 warning on py35_64bit: https://ci.appveyor.com/project/pythonnet/pythonnet-0kq5d/build/1.0.71/job/kkeja6tft2bhs697#L524 This is most likely issue with Appveyor CI, which incorrectly tags a pip upgrade warning as an exception. What I see in other instances is that build is failing on py34, py33 due to something else: https://ci.appveyor.com/project/pythonnet/pythonnet-0kq5d/build/1.0.71/job/8au8ysiax64gjouy#L398 This is due to using pre- C# 6.0 compiler like in this issue: I'm not sure how this happened to your branch! Especially since it compiles fine on py27 builds. Let me look closer. |
Sorry, something went wrong.
|
@jreback the pip 9.0 issue on Python35-x64 is caused by these global settings in your appveyor.yml:
It looks like pip is not updated to version 9.0 in this directory %PYTHON_BLD%, but used during pythonnet installation at the end. See successful and failing logs are here: py35_32bit: py35_64_bit: The quick solution is probably to add this line in install section of appveyor.yml:
|
Sorry, something went wrong.
|
@jreback I added what needs to be done before this pull request can be merged. But more importantly if you agree to MIT license transition, then someone can continue this effort. Can you please confirm? BTW, what is the benefit of using conda to build pip wheels and then install it with pip? |
Sorry, something went wrong.
|
i am away ok on license change conda packages are much easier to distribute esp when using a custom environment / much more standard in the community just have both |
Sorry, something went wrong.
|
these are not pip wheels at all further to above users can then have a dependency on this package (can't do this with wheels) |
Sorry, something went wrong.
|
Just as a heads up, I'm in favour of merging this (using conda myself) as soon as the remaining issues have been sorted out. |
Sorry, something went wrong.
|
ok, this is finally passing. turns out that you have to use a modern MSBuild even though you are using an older compiler (only matters on 3.3/3.4). |
Sorry, something went wrong.
|
@jreback this looks great! I see now that both a conda package and a wheel are built. Regarding adding an MIT license clause, can you please change this to ZPL 2.0 for now? There is still one contributor @tiran blocking transition to MIT license. Can you configure this to upload to anaconda.org once pythonnet account is "unlocked"? https://ci.appveyor.com/project/filmor/pythonnet/build/1.0.119/job/yalrdor5g871vujn#L533 I'm still having an issue with login to pythonnet account on anaconda.org: |
Sorry, something went wrong.
|
@jreback one more item - do you know how to expose the conda package as an artifact on appveyor? Right now only wheels are detected as downloadable artifacts by appveyor: https://ci.appveyor.com/project/filmor/pythonnet/build/1.0.119/job/yalrdor5g871vujn/artifacts |
Sorry, something went wrong.
|
@jreback to expose conda package as artifact, please add a post-build script to copy from %PYTHON_BLD%\conda-bld\**\*.tar.bz2 to %APPVEYOR_BUILD_FOLDER%\dist\ |
Sorry, something went wrong.
|
@denfromufa This recipe is designed for development builds, which you could also host on anaconda. |
Sorry, something went wrong.
closes pythonnet#210
|
@denfromufa ok this will now put the conda package in the dist folder (and now actually builds correct win-32/win-64). Since you normally upload the artifacts to anaconda where they are put in the correct win-32 or win-64 folder (as they are named the same), I am not sure that they artifacts are actually handled correctly by appveyor. |
Sorry, something went wrong.
|
@filmor @vmuriart @tonyroberts please review! |
Sorry, something went wrong.
|
I'm traveling so only got a quick glance at the code but... did we remove the original builds and only kept the conda recipe? |
Sorry, something went wrong.
|
And i just read the first post having an item check for this, so i guess that answered my question. nvm! 🤕 |
Sorry, something went wrong.
|
let's merge this for next release, so please wait |
Sorry, something went wrong.
|
@denfromufa Am I understanding you correctly in that we should hold off merging this for now? If yes, why? |
Sorry, something went wrong.
|
@filmor I'm merging this for v2.2.0 |
Sorry, something went wrong.
|
@jreback I just noticed that Appveyor enviroments have miniconda installed on them. Can we use those instead of downloading them for the tests? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
closes #210
builds a clr conda package
builds for 2.7/3.5 on windows (will simply fail on other platforms), should be easy to extend though
fixes the non-standard dev tag (-dev is not valid, should be .dev, but no big deal)
release tags should work, but not actually tests (e.g. should generate clr-v2.2.0-py35
the actual installation should really be into a site-packages\clr\ sub-dir in the target, but this just mimics how the wheels work.
agreement to transition to MIT license
fix old msbuild without C# 6.0 support for python 3.3 and 3.4 or add C# 6.0 compiler as nuget dependency
pip 9.0 issues
keep both python and conda builds by either having two appveyor.yml and two server configuration or merge them into one.