| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
No tests? :) |
Sorry, something went wrong.
|
That's why it reads "WIP" ;) |
Sorry, something went wrong.
|
Tests added, could someone comment on whether the XIncref there is correct? I take it GetInstHandle doesn't increase the ref-count by itself? |
Sorry, something went wrong.
|
@filmor you can always stress-test for memory growth of this exception in a for-loop. Looks like it is NOT needed to call XIncref like in this case: pythonnet/src/runtime/pyobject.cs Line 79 in 86937bb Note that PyObject(IntPtr tp) constructor does not incref the ref. count. |
Sorry, something went wrong.
|
@denfromufa @vmuriart @tonyroberts Please review. |
Sorry, something went wrong.
|
I don't think an incref is necessary as the CLRObject constructor creates a new python object (so reference count of 1) and never decrefs it. |
Sorry, something went wrong.
|
Yep, changed that already. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
No description provided.