FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support Python 3.6 by cgohlke · Pull Request #310 · pythonnet/pythonnet · GitHub

Support Python 3.6 - #310

Merged
filmor merged 6 commits into
pythonnet:masterfrom
cgohlke:Python36
Jan 7, 2017
Merged

Support Python 3.6#310
filmor merged 6 commits into
pythonnet:masterfrom
cgohlke:Python36

Conversation

cgohlke commented Jan 5, 2017
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #309 and #272 . Replaces #307.

Tested with Python 3.6 64-bit and msvc14 on Windows 10.

Copy link
Copy Markdown
Contributor

@cgohlke do you agree to transition from Zope to MIT license?

cgohlke commented Jan 5, 2017

Copy link
Copy Markdown
Contributor Author

@cgohlke do you agree to transition from Zope to MIT license?

Yes, I agree.

Comment thread src/runtime/interop35.cs Outdated


#if (PYTHON35)
#if (PYTHON35 || PYTHON36)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a leftover from trying to reuse the file for Python 3.6. It is no longer needed. I'll remove this change. Thank you.

vmuriart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Only concern I had was already covered by @filmor and had been fixed.

filmor merged commit 573f903 into pythonnet:master Jan 7, 2017
vmuriart mentioned this pull request Jan 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL