FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve tests by filmor · Pull Request #341 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Improve tests - #341

Closed
filmor wants to merge 5 commits into
pythonnet:masterfrom
filmor:improve-tests
ConversationCommits (5)ChecksFiles changed
Closed

Improve tests#341
filmor wants to merge 5 commits into
pythonnet:masterfrom
filmor:improve-tests

Conversation

filmor commented Jan 30, 2017

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

  • Simplifies testing by giving the test DLL access to the internals of Python.Runtime
  • Update NUnit to 3.5

Does this close any currently open issues?

Nope.

Any other comments?

Can be squashed.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

All N/A.

codecov-io commented Jan 30, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@f4d83cf).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d83cf...67e1b8f. Read the comment docs.

vmuriart commented Jan 30, 2017

Copy link
Copy Markdown
Contributor

Is the update to nunit3.5 required ? Opencover was a pain to setup with nunit2 (though now I see why you didn't want me freezing the version :-) )

vmuriart mentioned this pull request Jan 30, 2017
Merged
vmuriart added a commit that referenced this pull request Jan 30, 2017
Merge pull request #341 from filmor/improve-tests
b3bbdfb
vmuriart self-requested a review January 30, 2017 22:57

vmuriart commented Jan 30, 2017

Copy link
Copy Markdown
Contributor

Merged on master

vmuriart closed this Jan 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vmuriart vmuriart approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL