FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Console config, Add pyproj, Add PY3 to configurationmanager by vmuriart · Pull Request #346 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Fix Console config, Add pyproj, Add PY3 to configurationmanager - #346

Merged
vmuriart merged 6 commits into
pythonnet:masterfrom
vmuriart:project
Feb 2, 2017
ConversationCommits (6)ChecksFiles changed
Merged

Fix Console config, Add pyproj, Add PY3 to configurationmanager#346
vmuriart merged 6 commits into
pythonnet:masterfrom
vmuriart:project

Conversation

vmuriart commented Jan 31, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Standardizes build configurations across the projects (Console.csproj had its own thing going on)
Adds @denfromufa 's *.pyproj with corrected configurations

codecov-io commented Jan 31, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #346 into master will increase coverage by -0.7%.

@@            Coverage Diff            @@
##           master     #346     +/-   ##
=========================================
- Coverage   61.55%   60.85%   -0.7%     
=========================================
  Files          61       57      -4     
  Lines        5264     5089    -175     
  Branches      885      852     -33     
=========================================
- Hits         3240     3097    -143     
+ Misses       1805     1773     -32     
  Partials      219      219
Impacted Files Coverage Δ
src/runtime/delegateobject.cs 46.87% <ø> (-4.19%) ❌
src/runtime/converter.cs 74.86% <ø> (-1.25%) ❌
src/runtime/assemblymanager.cs 85.56% <ø> (-1.07%) ❌
setup.py 86.5% <ø> (-1%) ❌
src/runtime/exceptions.cs 71.81% <ø> (-0.99%) ❌
src/runtime/typemanager.cs 71.86% <ø> (-0.6%) ❌
src/runtime/interop36.cs
src/runtime/interop35.cs
src/runtime/interop34.cs
src/runtime/interop33.cs
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf4ba9...3f914ca. Read the comment docs.

vmuriart changed the title Fix MissingMinimumRules, Add pyproj Fix Console config, Add pyproj Jan 31, 2017
vmuriart changed the title Fix Console config, Add pyproj Fix Console config, Add pyproj, Add PY3 to configurationmanager Jan 31, 2017
vmuriart mentioned this pull request Jan 31, 2017
Merged
vmuriart force-pushed the project branch 2 times, most recently from 1234e3a to 8fe3f83 Compare January 31, 2017 22:19
filmor reviewed Feb 1, 2017
View reviewed changes
Comment thread .travis.yml
- export PYTHONPATH=`pwd`:$PYTHONPATH
- python src/tests/runtests.py
# - nunit-console src/embed_tests/bin/x64/ReleaseMono/Python.EmbeddingTest.dll
# - nunit-console src/embed_tests/bin/Python.EmbeddingTest.dll

filmor Feb 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is this still commented out?

vmuriart Feb 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It runs the tests but all say Cant find python.runtime error. Didn't have a chance to debug it. I'm keeping the tests paths updated though

filmor Feb 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Okay, fine by me then, but I'll open an issue for this, we should really start running those tests.

vmuriart Feb 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

On appveyor, when we run them on py3 they freeze and hang the testrunner until the build bot times out (30 minutes or so?).
I stress tested it on PY27 and its def fixed there. Ran 10 times no issues.

vmuriart Feb 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@filmor if we downgrade back to nunit 2.6.2 we can start running the tests. They will still fail, but nunit will gracefully fail and give us the error instead of whatever nunit3 is doing now

Update test PyImport path
3f914ca 
Changed when consolidate output paths
vmuriart merged commit 9d317bf into pythonnet:master Feb 2, 2017
vmuriart deleted the project branch February 2, 2017 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor filmor approved these changes
tonyroberts Awaiting requested review from tonyroberts
den-run-ai Awaiting requested review from den-run-ai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL