Import hook clean-up - #350
Conversation
Sorry, something went wrong.
| Runtime.XIncref(root.pyHandle); // we are using the module two times | ||
| Runtime.PyDict_SetItemString(dict, "CLR", root.pyHandle); | ||
| Runtime.PyDict_SetItemString(dict, "clr", root.pyHandle); | ||
| py_clr_module = root.pyHandle; // Alias handle for PY2/PY3 |
There was a problem hiding this comment.
@filmor Since you just worked on this, any reason this wouldn't work or is a bad idea?
Sorry, something went wrong.
There was a problem hiding this comment.
Nope, this should work fine, IMO.
Sorry, something went wrong.
Codecov Report@@ Coverage Diff @@
## master #350 +/- ##
==========================================
- Coverage 61.65% 61.62% -0.03%
==========================================
Files 61 61
Lines 5286 5280 -6
Branches 893 892 -1
==========================================
- Hits 3259 3254 -5
Misses 1806 1806
+ Partials 221 220 -1
Continue to review full report at Codecov.
|
Sorry, something went wrong.
| IntPtr mod = Runtime.PyDict_GetItemString(dict, "__builtin__"); | ||
| py_import = Runtime.PyObject_GetAttrString(mod, "__import__"); | ||
| #endif | ||
| py_import = Runtime.PyObject_GetAttrString(mod, "__import__"); |
There was a problem hiding this comment.
You could instead use PyEval_GetBuiltins() on both Py2 and 3.
Sorry, something went wrong.
There was a problem hiding this comment.
Saw this comment after I merged it in 😞
Sorry, something went wrong.
| Runtime.XIncref(root.pyHandle); // we are using the module two times | ||
| Runtime.PyDict_SetItemString(dict, "CLR", root.pyHandle); | ||
| Runtime.PyDict_SetItemString(dict, "clr", root.pyHandle); | ||
| py_clr_module = root.pyHandle; // Alias handle for PY2/PY3 |
There was a problem hiding this comment.
Nope, this should work fine, IMO.
Sorry, something went wrong.
What does this implement/fix? Explain your changes.
Refactor importhook.cs
Does this close any currently open issues?
I wish...