Enable Embedded Unit Tests - #353
Merged
vmuriart merged 1 commit intoFeb 3, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 61.55% 62.59% +1.04%
==========================================
Files 61 61
Lines 5264 5264
Branches 885 885
==========================================
+ Hits 3240 3295 +55
+ Misses 1805 1751 -54
+ Partials 219 218 -1
Continue to review full report at Codecov.
|
Sorry, something went wrong.
filmor
approved these changes
Feb 3, 2017
filmor
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Fine by me, but I'll try to figure out why it doesn't work with NUnit 3.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Same reason it doesn't work with nunit2 either 😄 . The difference is that nunit2 writes out the traceback and releases control back. For example, here you it failed to finalize (but the test itself passed). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Enables embedded unit tests on AppVeyor
Does this close any currently open issues?
Shows failing tests on python3 during finalization but can't reproduce locally. It isn't consistent on AppVeyor either.
Any other comments?
Downgrades nunit to 2.6.4. It can deal better with exceptions that occur during finalize, unit3 just freezes and holds the ci worker until AppVeyor times it out.
Checklist
Check all those that are applicable and complete.