FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove Mono.Unix dependency by vmuriart · Pull Request #360 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Remove Mono.Unix dependency - #360

Merged
vmuriart merged 3 commits into
pythonnet:masterfrom
vmuriart:remove_mono_unix_dep
Feb 6, 2017
ConversationCommits (3)ChecksFiles changed
Merged

Remove Mono.Unix dependency#360
vmuriart merged 3 commits into
pythonnet:masterfrom
vmuriart:remove_mono_unix_dep

Conversation

vmuriart commented Feb 5, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Remove dependency on Mono.Unix

Any other comments?

Work in progress

Currently failing but almost there. Something is screwy with encoding still.

AssertionError: u'SystemQ\x00\Ue83a0778\u7f7e\Ue83a0778\u7f7e\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00' != 'System'

vmuriart self-assigned this Feb 5, 2017

vmuriart commented Feb 5, 2017

Copy link
Copy Markdown
Contributor Author

@dmitriyse I've cherry picked your commit 0b988d2, but I can't get it to work (though it's almost there 👍).

Do you see anything that may be missing?

vmuriart force-pushed the remove_mono_unix_dep branch from ae4d704 to d2ba88a Compare February 6, 2017 18:34

codecov-io commented Feb 6, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #360 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   62.74%   62.74%           
=======================================
  Files          61       61           
  Lines        5251     5251           
  Branches      876      876           
=======================================
  Hits         3295     3295           
  Misses       1738     1738           
  Partials      218      218
Impacted Files Coverage Δ
src/runtime/runtime.cs 84.67% <ø> (ø) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f71a94...d2ba88a. Read the comment docs.

vmuriart commented Feb 6, 2017

Copy link
Copy Markdown
Contributor Author

Fixed it! We were passing the wrong size into the API call. It's ready for review/merge.

vmuriart changed the title [WIP] Remove mono unix dep Remove mono unix dep Feb 6, 2017
vmuriart changed the title Remove mono unix dep Remove Mono.Unix dependency Feb 6, 2017
tonyroberts approved these changes Feb 6, 2017
View reviewed changes

tonyroberts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

vmuriart merged commit 359e541 into pythonnet:master Feb 6, 2017
vmuriart deleted the remove_mono_unix_dep branch February 6, 2017 19:10
vmuriart referenced this pull request in dmitriyse/pythonnet Feb 7, 2017
Moving to CoreCLR build system.
38adb2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor Awaiting requested review from filmor
den-run-ai Awaiting requested review from den-run-ai
1 more reviewer
tonyroberts tonyroberts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

vmuriart

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL