FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrade NUnit to 3.6 by vmuriart · Pull Request #371 · pythonnet/pythonnet · GitHub

  1. pythonnet
  2. pythonnet

Repository navigation

Upgrade NUnit to 3.6 - #371

Merged
vmuriart merged 2 commits into
pythonnet:masterfrom
vmuriart:nunit3_6
Feb 14, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Upgrade NUnit to 3.6#371
vmuriart merged 2 commits into
pythonnet:masterfrom
vmuriart:nunit3_6

Conversation

vmuriart commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Since the embedded unit tests have been patched we can re-upgrade to NUnit3 from @filmor .

Does this close any currently open issues?

N/A

Any other comments?

On v.2.x of NUnit I'm noticing that the tests finish and hang for ~40 seconds before releasing control. on v3.x it gives some warnings but I'm not sure if thats related.

Personally I'm indifferent to prefer v2.x since it released control and occasionally print the traceback that was key to figuring the old problem out. But since that looks to be solved, I don't have a strong argument.

vmuriart requested review from den-run-ai and filmor February 9, 2017 21:06
vmuriart mentioned this pull request Feb 9, 2017
Closed

den-run-ai commented Feb 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

do you mean this warning?

https://ci.appveyor.com/project/pythonnet/pythonnet/build/master-377/job/rpml92u11q1k5kl8#L484

vmuriart commented Feb 10, 2017

Copy link
Copy Markdown
Contributor Author

That one.
Also I just remembered, for some reason this messes with coverage. It makes OpenCover go over the unittests code itself. Probably needs to filter the namespace.

codecov Bot commented Feb 13, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #371 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   63.18%   63.19%   +0.01%     
==========================================
  Files          61       61              
  Lines        5239     5239              
  Branches      876      876              
==========================================
+ Hits         3310     3311       +1     
  Misses       1709     1709              
+ Partials      220      219       -1
Impacted Files Coverage Δ
src/runtime/pythonexception.cs 66.07% <ø> (+1.78%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e2a87...5f86154. Read the comment docs.

vmuriart commented Feb 13, 2017

Copy link
Copy Markdown
Contributor Author

Fixed the aforementioned coverage issue. @filmor did you still want to upgrade to NUnit3?

Upgrade NUnit to 3.6
adc927f
Fix coverage w NUnit3; add OpenCover filter
5f86154 
NUnit3/OpenCover behavior changed.
Filter removes coverage from Embedded test files by
focusing only on types of Python.Runtime.*
vmuriart merged commit 5f86154 into pythonnet:master Feb 14, 2017
vmuriart added a commit that referenced this pull request Feb 14, 2017
Merge pull request #371 from vmuriart/nunit3_6
d7942c8 
Upgrade NUnit to 3.6
vmuriart deleted the nunit3_6 branch February 14, 2017 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor Awaiting requested review from filmor
1 more reviewer
den-run-ai den-run-ai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL