FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix for "handle is not inialized" crash on `clr.GetClrType(System.__class__)` by den-run-ai · Pull Request #607 · pythonnet/pythonnet · GitHub

fix for "handle is not inialized" crash on clr.GetClrType(System.__class__) - #607

Merged
den-run-ai merged 2 commits into
masterfrom
getclrtype
Jan 31, 2018
Merged

fix for "handle is not inialized" crash on clr.GetClrType(System.__class__)#607
den-run-ai merged 2 commits into
masterfrom
getclrtype

Conversation

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

fix for "handle is not initalized" crash on clr.GetClrType(System.__class__)

Does this close any currently open issues?

#606

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

codecov Bot commented Jan 28, 2018
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #607 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   77.01%   76.98%   -0.03%     
==========================================
  Files          64       64              
  Lines        5607     5609       +2     
  Branches      887      888       +1     
==========================================
  Hits         4318     4318              
- Misses       1001     1002       +1     
- Partials      288      289       +1
Flag Coverage Δ
#setup_linux 69.42% <ø> (ø) ⬆️
#setup_windows 76.16% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
src/runtime/managedtype.cs 46.15% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ec24c...19ec822. Read the comment docs.

dmitriyse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good fix. There are nothing to improve.

Copy link
Copy Markdown
Contributor Author

@dmitriyse merging according to new rules, since no objection is received

den-run-ai merged commit 9333d77 into master Jan 31, 2018
filmor deleted the getclrtype branch May 28, 2018 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL