FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added inline comment about dangers of multidomain usage by JanKrivanek · Pull Request #625 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Added inline comment about dangers of multidomain usage - #625

Merged
filmor merged 2 commits into
pythonnet:featuredfrom
JanKrivanek:patch-2
Oct 16, 2018
ConversationCommits (2)ChecksFiles changed
Merged

Added inline comment about dangers of multidomain usage#625
filmor merged 2 commits into
pythonnet:featuredfrom
JanKrivanek:patch-2

Conversation

JanKrivanek commented Feb 12, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

As requested here: #538 (comment)

What does this implement/fix? Explain your changes.

Just a commnet

Does this close any currently open issues?

No. But comment was requested

Any other comments?

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

JanKrivanek mentioned this pull request Feb 12, 2018
Closed
4 tasks

den-run-ai commented Jun 12, 2018

Copy link
Copy Markdown
Contributor

@jakrivan please update the changelog and add yourself to authors.

JanKrivanek added a commit to JanKrivanek/pythonnet that referenced this pull request Jun 12, 2018
Comment about dangers of multidomain usage pythonnet#625
bde0cae
JanKrivanek added a commit to JanKrivanek/pythonnet that referenced this pull request Jun 12, 2018
Comment about dangers of multidomain usage pythonnet#625
2f7d51a
JanKrivanek added a commit to JanKrivanek/pythonnet that referenced this pull request Jun 12, 2018
Comment about dangers of multidomain usage pythonnet#625
38fd9fb

codecov Bot commented Jun 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #625 into featured will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           featured    #625   +/-   ##
========================================
  Coverage      76.6%   76.6%           
========================================
  Files            71      71           
  Lines          6023    6023           
  Branches        961     961           
========================================
  Hits           4614    4614           
  Misses         1080    1080           
  Partials        329     329
Flag Coverage Δ
#setup_linux 69.42% <ø> (ø) ⬆️
#setup_windows 75.84% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/runtime/assemblymanager.cs 87.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6488c2a...9255b6b. Read the comment docs.

JanKrivanek commented Jun 12, 2018

Copy link
Copy Markdown
Contributor Author

@denfromufa Thanks. Done

filmor merged commit 0b9e6a1 into pythonnet:featured Oct 16, 2018

filmor commented Oct 16, 2018

Copy link
Copy Markdown
Member

Argh, didn't notice that this was against the "featured" branch. I'll cherry pick it on master...

den-run-ai commented Oct 16, 2018

Copy link
Copy Markdown
Contributor

@filmor would you like to revert this PR from featured branch managed by @dmitriyse ?

filmor commented Oct 16, 2018

Copy link
Copy Markdown
Member

Not particularly, no. This is just an additional comment and the featured branch (as essentially a fork) shouldn't exist in the first place.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

filmor

JanKrivanek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL