Repository navigation
Fix PyObject.GetHashCode - #677
Merged
filmor merged 2 commits intoMay 28, 2018
Merged
filmor merged 2 commits into
filmor merged 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Did you check that ulong's GetHashCode takes all bits into account? I can't find documentation on this, and apparently IntPtr.GetHashCode used to be broken in this regard. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I checked this with Reflector on .NET 4.7.2. Even if this is not working on lower versions, which I doubt for ulong, then the fix is still better than nothing. But it should be totally fine. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Cool, thank you very much :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #676