FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Catching exceptions from iterator MoveNext(), additional testing (issue #475, original pull request #523) by ArvidJB · Pull Request #693 · pythonnet/pythonnet · GitHub

  1. pythonnet
  2. pythonnet

Repository navigation

Catching exceptions from iterator MoveNext(), additional testing (issue #475, original pull request #523) - #693

Merged
filmor merged 6 commits into
pythonnet:masterfrom
ArvidJB:issue-475
Jun 26, 2018
ConversationCommits (6)ChecksFiles changed
Merged

Catching exceptions from iterator MoveNext(), additional testing (issue #475, original pull request #523)#693
filmor merged 6 commits into
pythonnet:masterfrom
ArvidJB:issue-475

Conversation

ArvidJB commented Jun 25, 2018 •
edited by filmor
Loading

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

This request contains the changes from #523 and adds some additional testing as requested in the comments on that request

Does this close any currently open issues?

Issue #475

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

ArvidJB mentioned this pull request Jun 25, 2018
Closed
3 tasks done

codecov Bot commented Jun 25, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #693 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage    76.9%   76.93%   +0.02%     
==========================================
  Files          63       63              
  Lines        5582     5589       +7     
  Branches      890      891       +1     
==========================================
+ Hits         4293     4300       +7     
  Misses        998      998              
  Partials      291      291
Flag Coverage Δ
#setup_linux 69.42% <ø> (ø) ⬆️
#setup_windows 76.11% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/runtime/iterator.cs 88.88% <100%> (+7.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545c549...2131292. Read the comment docs.

filmor merged commit 3eb7e58 into pythonnet:master Jun 26, 2018

filmor commented Jun 26, 2018

Copy link
Copy Markdown
Member

@rickardraysearch @ArvidJB Thank you very much for your contribution and sorry (especially to @rickardraysearch) for the long time until it was finally merged.

Just to clarify, the question I had was a pure lack-of-understanding question, I'm fine if this behaviour (i.e. always traverse exactly one level into the exception chain) if it's consistent with the rest.

den-run-ai mentioned this pull request Jun 26, 2018
Closed
ArvidJB deleted the issue-475 branch June 26, 2018 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL