What's left to do here?

Codecov Report

Merging #698 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage   77.12%   77.15%   +0.02%     
==========================================
  Files          62       63       +1     
  Lines        5688     5695       +7     
  Branches      903      904       +1     
==========================================
+ Hits         4387     4394       +7     
  Misses       1004     1004              
  Partials      297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 784190a...222874c. Read the comment docs.

There was one error in Travis CI and I was waiting for python 3.7 in appveyor. Also few changed to VS .sln/.proj files required.

I'm traveling extensively and plan to be looking at this again end of next week.

also official python 3.7 support in travis ci now requires xenial, not trusty. Hence this may create some unexpected issues with Mono:

travis-ci/travis-ci#9815 (comment)

so which of appveyor/pr or appveyor/branch is the one to take ?

@stonebig both branches should be identical.

Upgrading from Python 3.7-dev to official Python 3.7 on Travis CI is throwing a new error:

/opt/python/3.7.0/include/python3.7m/pythread.h:122:5: error: "Require native
      threads. See https://bugs.python.org/issue31370"
#   error "Require native threads. See https://bugs.python.org/issue31370"

https://travis-ci.org/pythonnet/pythonnet/jobs/415741697#L1999

Plus something in the Mono toolchain broke over the last 6 days, which is causing msbuild issues:

dotnet/msbuild#3604

+1 on removing Python-3.4 support.

@stonebig py34 is supported until March 2019:

https://www.python.org/dev/peps/pep-0429/

@stonebig py34 is supported until March 2019:

Personally I find 3.7 support much more compelling, if it's a one or the other type of thing. Also, anyone can still use the older version pythonnet for 3.4. There are many such cases where older libs QT etc. are not compatible in different ways, which is one of the reasons for virtual envs.

I don't know where this py34 discussion is coming from, it's no either/or wrt py37 support.

@filmor I suggested droping py34 because it was the one failing at the time https://ci.appveyor.com/project/pythonnet/pythonnet/build/master-1271

Ok, I'm really puzzled why travis ci is failing with mono/nuget/msbuild/xbuild toolchain. I just tried to reproduce the issue in Virtualbox with no luck:

https://gist.github.com/denfromufa/23557331aba2ad548eba2fbff84f2307

https://stackoverflow.com/questions/51988395/build-failures-with-mono-5-14-0-177-msbuild-15-0-nuget-4-7-1-on-travis-ci-but

Ok, I'm going to try previous versions of nuget and msbuild, like suggested in stackoverflow:

nuget 4.6, msbuild 15
nuget 4.7, msbuild 14
nuget 4.6, msbuild 14

And maybe then previous version of Mono (hopefully not!)

@denfromufa Is there anything left to do here?

@filmor justing waiting for appveyor builds 🕐

time for an official release ?

We're working on it, 6 merges in the last week, 7 PRs marked as 2.4.0 still to go.