FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix memory leaks due to spurious handle increment and add unit tests by williamsardar · Pull Request #704 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Fix memory leaks due to spurious handle increment and add unit tests - #704

Merged
filmor merged 6 commits into
pythonnet:masterfrom
williamsardar:master
Jul 23, 2018
ConversationCommits (6)ChecksFiles changed
Merged

Fix memory leaks due to spurious handle increment and add unit tests#704
filmor merged 6 commits into
pythonnet:masterfrom
williamsardar:master

Conversation

williamsardar commented Jul 20, 2018 •
edited by filmor
Loading

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Fix memory leaks due to spurious handle increment and add unit tests
...

Does this close any currently open issues?

Issue #691
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • [ x ] Make sure to include one or more tests for your change
  • [ x ] If an enhancement PR, please create docs and at best an example
  • [ x ] Add yourself to AUTHORS
  • [ x ] Updated the CHANGELOG

codecov Bot commented Jul 20, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #704 into master will increase coverage by 0.45%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #704      +/-   ##
=========================================
+ Coverage   76.94%   77.4%   +0.45%     
=========================================
  Files          63      63              
  Lines        5592    5589       -3     
  Branches      892     892              
=========================================
+ Hits         4303    4326      +23     
+ Misses        998     970      -28     
- Partials      291     293       +2
Flag Coverage Δ
#setup_linux 69.42% <ø> (ø) ⬆️
#setup_windows 76.57% <100%> (+0.45%) ⬆️
Impacted Files Coverage Δ
src/runtime/overload.cs 73.91% <ø> (+15.57%) ⬆️
src/runtime/methodbinding.cs 79.59% <ø> (-0.41%) ⬇️
src/runtime/constructorbinding.cs 39.43% <100%> (+29.57%) ⬆️
src/runtime/runtime.cs 91.37% <0%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611814c...a97a776. Read the comment docs.

filmor commented Jul 23, 2018

Copy link
Copy Markdown
Member

There are probably more issues like this in the code, essentially every class derived from ExtensionType does not need an additional Incref as far as I can see, since the PyType_GenericAlloc call in the constructor will already lead to a refcount of 1.

filmor merged commit fb84cd2 into pythonnet:master Jul 23, 2018

filmor commented Jul 23, 2018

Copy link
Copy Markdown
Member

Thank you very much for your contribution :)

williamsardar commented Jul 23, 2018

Copy link
Copy Markdown
Contributor Author

@filmor thanks for the merge. Any indication as to when the next release might happen?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL