Repository navigation
adding iterop37.cs to Python.Runtime.csproj and removing old TODO com… - #759
Merged
den-run-ai merged 2 commits intoNov 1, 2018
Merged
den-run-ai merged 2 commits into
den-run-ai merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Closed
Copy link
Copy Markdown
Contributor
|
@paulie4 I don't see the same issue in latest VS 2017 Enterprise (15.8.5) . But still we need to transition from unmanaged exports to a friendly fork dllexport: It builds fine using setup.py too. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
+ Coverage 77% 77.06% +0.05%
==========================================
Files 63 63
Lines 5741 5777 +36
Branches 907 907
==========================================
+ Hits 4421 4452 +31
- Misses 1021 1026 +5
Partials 299 299
Continue to review full report at Codecov.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ment, see #609, #720, and #609 (comment)
What does this implement/fix? Explain your changes.
iterop37.cs was missing from Python.Runtime.csproj
Does this close any currently open issues?
no, #609 and #720 were already closed, although, I don't know how #720 closed without this change...
Any other comments?
NOTE: to be able to build a usable clr.pyd using Visual Studio 2017, we had to run the following:
This is because we got the following error message in the build's output (even though the project looks like it built correctly), i.e. since the UnmanagedExports package seems to be looking for lib.exe in the wrong place for VS2017, we put the files where it was expecting to find them: