Repository navigation
Switch to using TrueDivide instead of Divide everywhere - #813
Merged
filmor merged 1 commit intoFeb 25, 2019
Merged
filmor merged 1 commit into
filmor merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixes #802. TrueDivide is supported in both Python 2 and 3 while Divide exists only in Python 2. This does mean that a simple division of numbers will behave differently in C# vs Python for Python 2, but it will at least behave the same way in C# independent of the Python version being used.
Copy link
Copy Markdown
Member
Author
|
The failing tests are completely unrelated, I don't have the time right now to fix the Travis build and it ran through on AppVeyor, so I'm going to merge this now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #802.
TrueDivide is supported in both Python 2 and 3 while Divide exists only in Python 2. This does mean that a simple division of numbers will behave differently in C# vs Python for Python 2, but it will at least
behave the same way in C# independent of the Python version being used.